Skip to content

feat: expose classmethod to build tortoise config#2162

Open
waketzheng wants to merge 5 commits intotortoise:developfrom
waketzheng:feat-typed-config
Open

feat: expose classmethod to build tortoise config#2162
waketzheng wants to merge 5 commits intotortoise:developfrom
waketzheng:feat-typed-config

Conversation

@waketzheng
Copy link
Copy Markdown
Contributor

Description

  1. The init function of tortoise.context.Context is too long
  2. Add a new classmethod to TortoiseConfig which is used for sharing config between contexts

Motivation and Context

Base on #2159

This function has too many lines; shorten it.

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 31, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing waketzheng:feat-typed-config (accf77b) with develop (2df46d0)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant